linux-kernel - Re: [PATCH 7/7] usb: phy: msm: Lindent the code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 25 Jul 2013 16:40:51 +0300
From:	"Ivan T. Ivanov" <iivanov@...sol.com>
To:	balbi@...com
Cc:	linux-arm-msm@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 7/7] usb: phy: msm: Lindent the code


Hi, 

On Wed, 2013-07-24 at 15:22 +0300, Felipe Balbi wrote:
> On Mon, Jun 24, 2013 at 06:27:44PM +0300, Ivan T. Ivanov wrote:
> > From: "Ivan T. Ivanov" <iivanov@...sol.com>
> > 
> > Cc: Felipe Balbi <balbi@...com>
> > Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > Cc: linux-usb@...r.kernel.org
> > Cc: linux-kernel@...r.kernel.org
> > 
> > Signed-off-by: Ivan T. Ivanov <iivanov@...sol.com>
> 
> I really don't like blind Lindent patches... sometimes it makes things
> even worse.

It is not exactly blindly. I have removed some of the changes in the
platform_driver structure. 

> 
> > ---
> >  drivers/usb/phy/phy-msm-usb.c |   99 ++++++++++++++++++++++-------------------
> >  1 file changed, 52 insertions(+), 47 deletions(-)
> > 
> > diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy-msm-usb.c
> > index 6d05085..111f454 100644
> > --- a/drivers/usb/phy/phy-msm-usb.c
> > +++ b/drivers/usb/phy/phy-msm-usb.c
> > @@ -64,8 +64,8 @@ static int msm_hsusb_init_vddcx(struct msm_otg *motg, int init)
> >  
> >  	if (init) {
> >  		ret = regulator_set_voltage(motg->vddcx,
> > -				USB_PHY_VDD_DIG_VOL_MIN,
> > -				USB_PHY_VDD_DIG_VOL_MAX);
> > +					    USB_PHY_VDD_DIG_VOL_MIN,
> > +					    USB_PHY_VDD_DIG_VOL_MAX);
> 
> like here, what's the point ?

It makes indentation the same like the majority of the code.
I could drop this patch if you like.

Thanks,
Ivan


> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/