linux-kernel - Re: [PATCH 7/7] usb: phy: msm: Lindent the code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130725142208.GC16106@radagast>
Date:	Thu, 25 Jul 2013 17:22:08 +0300
From:	Felipe Balbi <balbi@...com>
To:	"Ivan T. Ivanov" <iivanov@...sol.com>
CC:	<balbi@...com>, <linux-arm-msm@...r.kernel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	<linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 7/7] usb: phy: msm: Lindent the code

Hi,

On Thu, Jul 25, 2013 at 04:40:51PM +0300, Ivan T. Ivanov wrote:
> > > diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy-msm-usb.c
> > > index 6d05085..111f454 100644
> > > --- a/drivers/usb/phy/phy-msm-usb.c
> > > +++ b/drivers/usb/phy/phy-msm-usb.c
> > > @@ -64,8 +64,8 @@ static int msm_hsusb_init_vddcx(struct msm_otg *motg, int init)
> > >  
> > >  	if (init) {
> > >  		ret = regulator_set_voltage(motg->vddcx,
> > > -				USB_PHY_VDD_DIG_VOL_MIN,
> > > -				USB_PHY_VDD_DIG_VOL_MAX);
> > > +					    USB_PHY_VDD_DIG_VOL_MIN,
> > > +					    USB_PHY_VDD_DIG_VOL_MAX);
> > 
> > like here, what's the point ?
> 
> It makes indentation the same like the majority of the code.
> I could drop this patch if you like.

yeah, I don't think it's worth to have this patch. Just looked at the
driver and, at least to my eyes, it didn't look all that bad. Matter of
taste though

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)