[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <51F12668.8000400@suse.cz>
Date: Thu, 25 Jul 2013 15:21:44 +0200
From: Michal Marek <mmarek@...e.cz>
To: Frank Haverkamp <haver@...t.ibm.com>
Cc: linux-kernel@...r.kernel.org, arnd@...db.de,
gregkh@...uxfoundation.org, cody@...ux.vnet.ibm.com,
schwidefsky@...ibm.com, utz.bacher@...ibm.com, jsvogt@...ibm.com,
MIJUNG@...ibm.com, cascardo@...ux.vnet.ibm.com, michael@...ra.de
Subject: Re: [PATCH] Generic WorkQueue Engine (GenWQE) device driver
On 25.7.2013 10:28, Frank Haverkamp wrote:
> + dev_info(&pci_dev->dev, "GenWQE driver version: %s (build %s) %s%u\n",
> + DRV_VERS_STRING, __DATE__, GENWQE_DEVNAME, cd->card_idx);
[...]
> + len += scnprintf(&buf[len], PAGE_SIZE - len,
> + "GenWQE driver version: %s (build %s)\n"
> + " Device Name/Type: %s %s CardIdx: %d\n"
> + " SLU/APP Config : 0x%016llx/0x%016llx\n"
> + " Build Date/Type : %u/%x/%u %s\n"
> + " Base Clock : %u MHz\n"
> + " Arch/SVN Release: %u/%llx\n"
> + " Bitstream : %llx\n",
> + DRV_VERS_STRING, __DATE__, dev_name(&pci_dev->dev),
Please remove the __DATE__ macros, so that the generated object code
does not literally change with the phase of the moon.
Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists