linux-kernel - Re: [PATCH 2/2] regulator: Add Dialog DA9063 voltage regulators support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130725180145.GL9858@sirena.org.uk>
Date:	Thu, 25 Jul 2013 19:01:45 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Philipp Zabel <p.zabel@...gutronix.de>
Cc:	linux-kernel@...r.kernel.org, Lee Jones <lee.jones@...aro.org>,
	Krystian Garbaciak <krystian.garbaciak@...semi.com>
Subject: Re: [PATCH 2/2] regulator: Add Dialog DA9063 voltage regulators
 support.

On Thu, Jul 25, 2013 at 07:35:39PM +0200, Philipp Zabel wrote:
> Am Mittwoch, den 24.07.2013, 18:29 +0100 schrieb Mark Brown:

> > This looks like it should be generic (and there is actually a
> > regmap_field API for bitfields...).

> Indeed. I'm a bit unhappy about having to split all the masks into lsb and msb
> only to have regmap_field_init combine them back into a mask, though.
> Could we perhaps change struct reg_field to contain reg and mask, and then also use
> this for the regulator_desc vsel/apply/enable/bypass_reg/mask fields?

Well, the other option is to define regmap regulator helpers for
everything where there's overlap and just do that.  The helpers cover a
bunch of common things but there's going to be room for more.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)