linux-kernel - Re: [PATCH 1/2] mfd: Add Dialog DA9063 core driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130729154614.GA7704@gmail.com>
Date:	Mon, 29 Jul 2013 16:46:14 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Philipp Zabel <p.zabel@...gutronix.de>
Cc:	linux-kernel@...r.kernel.org, Mark Brown <broonie@...nel.org>,
	Krystian Garbaciak <krystian.garbaciak@...semi.com>,
	Samuel Ortiz <sameo@...ux.intel.com>
Subject: Re: [PATCH 1/2] mfd: Add Dialog DA9063 core driver.

> > > > Signed-off-by: Krystian Garbaciak <krystian.garbaciak@...semi.com>
> > > > Signed-off-by: Philipp Zabel <p.zabel@...gutronix.de>
> > > > ---
> > > >  drivers/mfd/Kconfig                  |   12 +
> > > >  drivers/mfd/Makefile                 |    3 +
> > > >  drivers/mfd/da9063-core.c            |  177 ++++++
> > > >  drivers/mfd/da9063-i2c.c             |  197 ++++++
> > > >  drivers/mfd/da9063-irq.c             |  193 ++++++
> > > >  include/linux/mfd/da9063/core.h      |  110 ++++
> > > >  include/linux/mfd/da9063/pdata.h     |  114 ++++
> > > >  include/linux/mfd/da9063/registers.h | 1090 ++++++++++++++++++++++++++++++++++
> > > >  8 files changed, 1896 insertions(+)
> > > 
> > > Whoah!! Who's going to want to review a 2k line patch?
> 
> Well, most of those lines consist of the register and bit(field)
> definitions and the assignment of those to regmap and regmap-irq.
> 
> I could split this into (core+i2c) and (irq) parts if you insist.

I won't insist on it, but bear in mind it might take me longer to set
aside enough time to review the patch than if it were broken up. In
the latter case I could pick at it throughout the working day.

> > > Any chance you can split this stuff up into more 'bite sized' patches?

-- 
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/