[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20130729155727.GA11830@zurbaran>
Date: Mon, 29 Jul 2013 17:57:27 +0200
From: Samuel Ortiz <sameo@...ux.intel.com>
To: Lee Jones <lee.jones@...aro.org>
Cc: Philipp Zabel <p.zabel@...gutronix.de>,
linux-kernel@...r.kernel.org, Mark Brown <broonie@...nel.org>,
Krystian Garbaciak <krystian.garbaciak@...semi.com>
Subject: Re: [PATCH 1/2] mfd: Add Dialog DA9063 core driver.
Hi Lee,
On Mon, Jul 29, 2013 at 04:46:14PM +0100, Lee Jones wrote:
> > > > > Signed-off-by: Krystian Garbaciak <krystian.garbaciak@...semi.com>
> > > > > Signed-off-by: Philipp Zabel <p.zabel@...gutronix.de>
> > > > > ---
> > > > > drivers/mfd/Kconfig | 12 +
> > > > > drivers/mfd/Makefile | 3 +
> > > > > drivers/mfd/da9063-core.c | 177 ++++++
> > > > > drivers/mfd/da9063-i2c.c | 197 ++++++
> > > > > drivers/mfd/da9063-irq.c | 193 ++++++
> > > > > include/linux/mfd/da9063/core.h | 110 ++++
> > > > > include/linux/mfd/da9063/pdata.h | 114 ++++
> > > > > include/linux/mfd/da9063/registers.h | 1090 ++++++++++++++++++++++++++++++++++
> > > > > 8 files changed, 1896 insertions(+)
> > > >
> > > > Whoah!! Who's going to want to review a 2k line patch?
> >
> > Well, most of those lines consist of the register and bit(field)
> > definitions and the assignment of those to regmap and regmap-irq.
> >
> > I could split this into (core+i2c) and (irq) parts if you insist.
>
> I won't insist on it,
I would. Smaller patches are easier to review, track and bisect.
So if you can logically split this patch into smaller pieces,, then
please do so.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists