linux-kernel - Re: [PATCH 1/3] Input: omap-keypad: Enable wakeup capability for keypad.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <51F2AAA6.6090708@ti.com>
Date:	Fri, 26 Jul 2013 19:58:14 +0300
From:	Illia Smyrnov <x0194613@...com>
To:	Illia Smyrnov <illia.smyrnov@...com>
CC:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	<linux-input@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<linux-omap@...r.kernel.org>
Subject: Re: [PATCH 1/3] Input: omap-keypad: Enable wakeup capability for
 keypad.

Sorry,
this patch is incomplete and was sent by mistake.
I will sent v2

On 07/26/2013 07:29 PM, Illia Smyrnov wrote:
> Enable/disable IRQ wake in suspend/resume handlers
> to make the keypad wakeup capable.
>
> Signed-off-by: Illia Smyrnov <illia.smyrnov@...com>
> ---
>   drivers/input/keyboard/omap4-keypad.c |   38 +++++++++++++++++++++++++++++++++
>   1 file changed, 38 insertions(+)
>
> diff --git a/drivers/input/keyboard/omap4-keypad.c b/drivers/input/keyboard/omap4-keypad.c
> index 0244262..5f0a2c7 100644
> --- a/drivers/input/keyboard/omap4-keypad.c
> +++ b/drivers/input/keyboard/omap4-keypad.c
> @@ -74,6 +74,7 @@ struct omap4_keypad {
>   	struct input_dev *input;
>
>   	void __iomem *base;
> +	bool irq_wake_enabled;
>   	unsigned int irq;
>
>   	unsigned int rows;
> @@ -380,6 +381,7 @@ static int omap4_keypad_probe(struct platform_device *pdev)
>   		goto err_free_input;
>   	}
>
> +	device_init_wakeup(&pdev->dev, true);
>   	pm_runtime_put_sync(&pdev->dev);
>
>   	error = input_register_device(keypad_data->input);
> @@ -393,6 +395,7 @@ static int omap4_keypad_probe(struct platform_device *pdev)
>
>   err_pm_disable:
>   	pm_runtime_disable(&pdev->dev);
> +	device_init_wakeup(&pdev->dev, false);
>   	free_irq(keypad_data->irq, keypad_data);
>   err_free_keymap:
>   	kfree(keypad_data->keymap);
> @@ -418,6 +421,8 @@ static int omap4_keypad_remove(struct platform_device *pdev)
>
>   	pm_runtime_disable(&pdev->dev);
>
> +	device_init_wakeup(&pdev->dev, false);
> +
>   	input_unregister_device(keypad_data->input);
>
>   	iounmap(keypad_data->base);
> @@ -439,12 +444,45 @@ static const struct of_device_id omap_keypad_dt_match[] = {
>   MODULE_DEVICE_TABLE(of, omap_keypad_dt_match);
>   #endif
>
> +#ifdef CONFIG_PM_SLEEP
> +static int omap4_keypad_suspend(struct device *dev)
> +{
> +	int error;
> +
> +	if (device_may_wakeup(&pdev->dev)) {
> +		error = enable_irq_wake(keypad_data->irq);
> +		if (!error)
> +			keypad_data->irq_wake_enabled = true;
> +	}
> +
> +	return 0;
> +}
> +
> +static int omap4_keypad_resume(struct device *dev)
> +{
> +	if (device_may_wakeup(&pdev->dev) && keypad_data->irq_wake_enabled) {
> +		disable_irq_wake(keypad_data->irq);
> +		keypad_data->irq_wake_enabled = false;
> +	}
> +
> +	return 0;
> +}
> +
> +static SIMPLE_DEV_PM_OPS(omap4_keypad_pm_ops, omap4_keypad_suspend,
> +				omap4_keypad_resume);
> +
> +#define OMAP4_KEYPAD_PM_OPS (&omap4_keypad_pm_ops)
> +#else
> +#define OMAP4_KEYPAD_PM_OPS NULL
> +#endif
> +
>   static struct platform_driver omap4_keypad_driver = {
>   	.probe		= omap4_keypad_probe,
>   	.remove		= omap4_keypad_remove,
>   	.driver		= {
>   		.name	= "omap4-keypad",
>   		.owner	= THIS_MODULE,
> +		.pm	= OMAP4_KEYPAD_PM_OPS,
>   		.of_match_table = of_match_ptr(omap_keypad_dt_match),
>   	},
>   };
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/