| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <51F2AAC5.6020808@zytor.com> Date: Fri, 26 Jul 2013 09:58:45 -0700 From: "H. Peter Anvin" <hpa@...or.com> To: Jesse Barnes <jbarnes@...tuousgeek.org> CC: intel-gfx@...ts.freedesktop.org, linux-kernel@...r.kernel.org, mingo@...e.hu, tglx@...utronix.de, torvalds@...ux-foundation.org Subject: Re: [PATCH 2/2] x86: add early quirk for reserving Intel graphics stolen memory v3 On 07/25/2013 09:37 AM, Jesse Barnes wrote: > Systems with Intel graphics controllers set aside memory exclusively for > + /* > + * Almost universally we can find the Graphics Base of Stolen Memory > + * at offset 0x5c in the igfx configuration space. On a few (desktop) > + * machines this is also mirrored in the bridge device at different > + * locations, or in the MCHBAR. > + */ This comment makes me nervous. It isn't clear to me if it is saying: - All igfx devices has the graphics base at 0x5c, a few have it in other places, too (which doesn't matter, we can use 0x5c anyway), or - Most igfx devices have the graphics base at 0x5c, some don't, and we hope and pray we're not on one of those systems because we're not checking. I assume it is the former, but it really needs to be phrased better. -hpa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists