linux-kernel - [resubmit2] [PATCH] spi: spi-davinci: Fix direction in dma_map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <1388690.s58sU4PUYE@p2400>
Date:	Mon, 29 Jul 2013 20:54:09 +0200
From:	Christian Eggers <ceggers@....de>
To:	spi-devel-general@...ts.sourceforge.net,
	Mark Brown <broonie@...nel.org>
Cc:	linux-kernel@...r.kernel.org, trivial@...nel.org
Subject: [resubmit2] [PATCH] spi: spi-davinci: Fix direction in dma_map_single()

The following patch I already sent on 2013-04-18 and 2013-06-06. 
Unfortunately it hasn't been committed yet.

Commit 048177ce3b3962852fd34a7e04938959271c7e70 (spi: spi-davinci: 
convert to DMA engine API) introduced a regression: dma_map_single() 
is called with direction DMA_FROM_DEVICE for rx and for tx.

Signed-off-by: Christian Eggers <ceggers@....de>
Cc: stable@...r.kernel.org # v3.7.x+
Acked-by: Matt Porter <mporter@...com>
---
--- drivers/spi/spi-davinci.c.orig	2013-04-18 20:54:02.728719412 +0200
+++ drivers/spi/spi-davinci.c	2013-04-18 20:54:51.900623956 +0200
@@ -608,7 +608,7 @@ static int davinci_spi_bufs(struct spi_d
 		else
 			buf = (void *)t->tx_buf;
 		t->tx_dma = dma_map_single(&spi->dev, buf,
-				t->len, DMA_FROM_DEVICE);
+				t->len, DMA_TO_DEVICE);
 		if (!t->tx_dma) {
 			ret = -EFAULT;
 			goto err_tx_map;

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/