linux-kernel - Re: [resubmit2] [PATCH] spi: spi-davinci: Fix direction in dma_map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 29 Jul 2013 20:33:57 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Christian Eggers <ceggers@....de>
Cc:	spi-devel-general@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org, trivial@...nel.org
Subject: Re: [resubmit2] [PATCH] spi: spi-davinci: Fix direction in
 dma_map_single()

On Mon, Jul 29, 2013 at 08:54:09PM +0200, Christian Eggers wrote:

> The following patch I already sent on 2013-04-18 and 2013-06-06. 
> Unfortunately it hasn't been committed yet.

I'm not sure where you submitted this to but it doesn't appear to have
been to either me or to the mailing list.  If you want a patch applying
you need to send it to the maintainer as covered in SubmittingPatches.
Google and your current post suggest it went to lkml and the retired
sourceforge list...

As also covered in SubmittingPatches you should also not include things
like this in the body of the commit message, put them after the ---
where they will be stripped automatically by tools like git am.

> Commit 048177ce3b3962852fd34a7e04938959271c7e70 (spi: spi-davinci: 
> convert to DMA engine API) introduced a regression: dma_map_single() 
> is called with direction DMA_FROM_DEVICE for rx and for tx.

This doesn't apply automatically since:

> ---
> --- drivers/spi/spi-davinci.c.orig      2013-04-18 20:54:02.728719412 +0200
> +++ drivers/spi/spi-davinci.c   2013-04-18 20:54:51.900623956 +0200

you've generated the patch in -p0 format not -p1 format as covered in
SubmittingPatches.  I fixed this up manually but please do follow the
process in SubmittingPatches, it makes life easier.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)