linux-kernel - Re: [PATCH] usb: phy-samsung-usb: Simplify PMU register handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <51F6E2C7.9000407@gmail.com>
Date:	Mon, 29 Jul 2013 23:46:47 +0200
From:	Sylwester Nawrocki <sylvester.nawrocki@...il.com>
To:	Julius Werner <jwerner@...omium.org>
CC:	Felipe Balbi <balbi@...com>, LKML <linux-kernel@...r.kernel.org>,
	linux-samsung-soc@...r.kernel.org,
	Tomasz Figa <t.figa@...sung.com>,
	Vivek Gautam <gautam.vivek@...sung.com>,
	devicetree@...r.kernel.org, Kamil Debski <k.debski@...sung.com>
Subject: Re: [PATCH] usb: phy-samsung-usb: Simplify PMU register handling

On 07/29/2013 11:12 PM, Julius Werner wrote:
>>> -       if (sphy->phy_type == USB_PHY_TYPE_DEVICE) {
>>> -               reg = sphy->pmuregs + sphy->drv_data->devphy_reg_offset;
>>> -               en_mask = sphy->drv_data->devphy_en_mask;
>>> -       } else if (sphy->phy_type == USB_PHY_TYPE_HOST) {
>>> -               reg = sphy->pmuregs + sphy->drv_data->hostphy_reg_offset;
>>> -               en_mask = sphy->drv_data->hostphy_en_mask;
>>> -       }
>>
>>
>> How is en_mask supposed to get initialized, now when this code is removed ?
>> It's always 0 now, isn't it ?
>>
>
> Whoops... oh, I'm really sorry about that. I ported the patch from a
> branch with slightly different code there and overlooked this. Thanks
> for catching it, will send v2 in a minute.

v2 looks good, thanks. :) As a side note, we are working on the USB PHYs
driver using the generic PHY framework (actually Kamil is working on that).
Thus it is likely the original driver will get replaced in near future by
something else. Not sure when that happens exactly but I suspect it is
not worth to invest in the Samsung USB PHY drivers at drivers/usb/phy/
too much and introduce changes, especially in *.dts, that won't be for
long time in use. Perhaps Kamil can provide more details on which devices
are initially going to be covered by the new driver.

--
Thanks,
Sylwester
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/