linux-kernel - Re: [PATCH] usb: phy-samsung-usb: Simplify PMU register handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAODwPW-hxtazAO=scZR+ZWK5hwdWMQXFBeYLd1qqau+a9tMCvA@mail.gmail.com>
Date:	Mon, 29 Jul 2013 14:12:13 -0700
From:	Julius Werner <jwerner@...omium.org>
To:	Sylwester Nawrocki <sylvester.nawrocki@...il.com>
Cc:	Julius Werner <jwerner@...omium.org>, Felipe Balbi <balbi@...com>,
	LKML <linux-kernel@...r.kernel.org>,
	linux-samsung-soc@...r.kernel.org,
	Tomasz Figa <t.figa@...sung.com>,
	Vivek Gautam <gautam.vivek@...sung.com>,
	devicetree@...r.kernel.org
Subject: Re: [PATCH] usb: phy-samsung-usb: Simplify PMU register handling

>> -       if (sphy->phy_type == USB_PHY_TYPE_DEVICE) {
>> -               reg = sphy->pmuregs + sphy->drv_data->devphy_reg_offset;
>> -               en_mask = sphy->drv_data->devphy_en_mask;
>> -       } else if (sphy->phy_type == USB_PHY_TYPE_HOST) {
>> -               reg = sphy->pmuregs + sphy->drv_data->hostphy_reg_offset;
>> -               en_mask = sphy->drv_data->hostphy_en_mask;
>> -       }
>
>
> How is en_mask supposed to get initialized, now when this code is removed ?
> It's always 0 now, isn't it ?
>

Whoops... oh, I'm really sorry about that. I ported the patch from a
branch with slightly different code there and overlooked this. Thanks
for catching it, will send v2 in a minute.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/