linux-kernel - Re: [char-misc 3.11 V2] mei: me: fix hardware reset flow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <B8EFE96D1287C24090BAD9D858E15E6174E4A6@sisaex01sj>
Date:	Tue, 30 Jul 2013 14:27:06 +0000
From:	Shuah Khan <shuah.kh@...sung.com>
To:	Greg KH <gregkh@...uxfoundation.org>
Cc:	Tomas Winkler <tomas.winkler@...el.com>,
	"arnd@...db.de" <arnd@...db.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Konstantin Khlebnikov <khlebnikov@...nvz.org>,
	Shuah Khan <shuah.kh@...sung.com>
Subject: Re: [char-misc 3.11 V2] mei: me: fix hardware reset flow

On 07/30/2013 08:21 AM, Greg KH wrote:
> On Tue, Jul 30, 2013 at 02:11:51PM +0300, Tomas Winkler wrote:
>> Both H_IS and H_IE needs to be set to receive H_RDY
>> interrupt
>>
>> 1. Assert H_IS to clear the interrupts during hw reset
>> and use mei_me_reg_write instead of mei_hcsr_set as the later
>> strips down the H_IS
>>
>> 2. fix interrupt disablement embarrassing typo
>>    hcsr |= ~H_IE -> hcsr &= ~H_IE;
>> this will remove the unwanted interrupt on power down
>>
>> 3. remove useless debug print outs
>>
>> Cc: Shuah Khan <shuah.kh@...sung.com>
>> Cc: Konstantin Khlebnikov <khlebnikov@...nvz.org>
>> Signed-off-by: Tomas Winkler <tomas.winkler@...el.com>
>> ---
>>
>> V2: Fixed typo in Shuah email
>>
>> Hope this finally resolve the ME reset issue for all
>
> Can I get a "Tested-by:" from someone to ensure that it really does
> solve the problem?
>
> thanks,
>
> greg k-h
>

I will test it on my system and let you know.

-- Shuah

Shuah Khan, Linux Kernel Developer - Open Source Group Samsung Research 
America (Silicon Valley) shuah.kh@...sung.com | (970) 672-0658
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/