linux-kernel - Re: [PATCH v2 2/4] phy: phy-amxxxx-usb: Add PHY driver for amxxxx platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51F7CCB7.4040305@ti.com>
Date:	Tue, 30 Jul 2013 19:54:55 +0530
From:	George Cherian <george.cherian@...com>
To:	Sebastian Andrzej Siewior <bigeasy@...utronix.de>
CC:	<linux-usb@...r.kernel.org>, <balbi@...com>,
	<linux-kernel@...r.kernel.org>, <gregkh@...uxfoundation.org>,
	<linux-omap@...r.kernel.org>, <kishon@...com>
Subject: Re: [PATCH v2 2/4] phy: phy-amxxxx-usb: Add PHY driver for amxxxx
 platform

On 7/30/2013 2:23 PM, Sebastian Andrzej Siewior wrote:
> On 07/30/2013 07:19 AM, George Cherian wrote:
>>> So from what I see now, it is most likely the easiest thing to just add
>>> that wakeup to the phy driver I posted. Do you agree?
>> The whole idea of writing a seperate phy driver was to use the generic
>> phy framework
>> and most of the amxxxx devices have the same phy (eg am335x, am437x).
>> Now since the register is shared in am335x for phy_wkup (Not in the case
>> of am437x)
>> how are you planning to  map it. I feel if omap_control_usb can delegate
>> the writes
>> to phy_wkup, phy_on and phy_off, it makes the life simpler.
> that omap-control driver looks a little strange. It has a compatible
> field saying ti,omap-control-usb and then it requires additionally a
> ti,type property which should have been avoided.

ti,type property is to differentiate between usb2 and usb3 phy for a 
single soc.
for eg: OMAP5 has both usb2 and usb3 phy


-- 
-George

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/