linux-kernel - Re: + fs-binfmts-add-a-name-field-to-the-binfmt-struct.patch added to -mm tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20130731185347.GA26439@redhat.com>
Date:	Wed, 31 Jul 2013 20:53:47 +0200
From:	Oleg Nesterov <oleg@...hat.com>
To:	Zach Levis <zach@...hsthings.com>,
	Zach Levis <zml@...ux.vnet.ibm.com>,
	Al Viro <viro@...iv.linux.org.uk>,
	Andrew Morton <akpm@...ux-foundation.org>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: + fs-binfmts-add-a-name-field-to-the-binfmt-struct.patch added
	to -mm tree

> From: Zach Levis <zml@...ux.vnet.ibm.com>
> Subject: fs/binfmts: add a name field to the binfmt struct
>
> Adding the name field helps when printing error messages referring to
> specific binfmts.

OK, but...

>  static struct linux_binfmt elf_format = {
> +	.name		= "elf",
>  	.module		= THIS_MODULE,
>  	.load_binary	= load_elf_binary,
>  	.load_shlib	= load_elf_library,
> diff -puN fs/binfmt_elf_fdpic.c~fs-binfmts-add-a-name-field-to-the-binfmt-struct fs/binfmt_elf_fdpic.c
> --- a/fs/binfmt_elf_fdpic.c~fs-binfmts-add-a-name-field-to-the-binfmt-struct
> +++ a/fs/binfmt_elf_fdpic.c
> @@ -81,6 +81,7 @@ static int elf_fdpic_core_dump(struct co
>  #endif
>
>  static struct linux_binfmt elf_fdpic_format = {
> +	.name		= "FDPIC ELF",

The naming doesn't look consistent, but this is minor.

I think this is not compat-friendly. If we add .name then I think
compat_elf_format should have another name != "elf".

Not that I think this is really wrong, but still.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/