linux-kernel - Re: [PATCH] USB: ohci-at91: add usb_clk for transition to common clk framework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51FA9B20.3080304@cogentembedded.com>
Date:	Thu, 01 Aug 2013 21:30:08 +0400
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Alan Stern <stern@...land.harvard.edu>
CC:	boris brezillon <b.brezillon@...rkiz.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Nicolas Ferre <nicolas.ferre@...el.com>,
	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>,
	Ludovic Desroches <ludovic.desroches@...el.com>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] USB: ohci-at91: add usb_clk for transition to common
 clk framework

Hello.

On 08/01/2013 07:56 PM, Alan Stern wrote:

>>> What happens if uclk isn't found but it is needed?

>> It will not fail but I guess the usb host won't work as the clock won't
>> be correctly
>> configured.

>> I agree with you: this is not a good solution.

>> Another option is to keep the previous version of this patch and put
>> uclk handling
>> in "#ifdef CONFIG_COMMON_CLK #endif" sections.

>> Would this be acceptable ?

> Yes.  However, a more elegant approach is to protect the relevant
> statements with: if (defined(CONFIG_COMMON_CLK)).  This preprocessor

    You probably meant IS_ENABLED() or IS_BUIILTIN()? Or is there something I 
don't know about gcc preprocessor?

> evaluates this to a 0 or 1, so the compiler will not generate output
> for the protected source code if the symbol isn't defined.

> Alan Stern

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/