linux-kernel - Re: [PATCH v7] watchdog: Add MOXA ART watchdog driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACmBeS3M+3Bah849N9jC6TFft4SN=ZhZfUh=65zf5Lf2d+VoQg@mail.gmail.com>
Date:	Fri, 2 Aug 2013 16:55:20 +0200
From:	Jonas Jensen <jonas.jensen@...il.com>
To:	Mark Rutland <mark.rutland@....com>
Cc:	"linux-watchdog@...r.kernel.org" <linux-watchdog@...r.kernel.org>,
	"arnd@...db.de" <arnd@...db.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"wim@...ana.be" <wim@...ana.be>, "arm@...nel.org" <arm@...nel.org>,
	"linux@...ck-us.net" <linux@...ck-us.net>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v7] watchdog: Add MOXA ART watchdog driver

Hi Mark,

Thanks for the replies.

On 2 August 2013 13:41, Mark Rutland <mark.rutland@....com> wrote:
> It would be nice to have a fuller description here.

I have tried to elaborate the commit message, please point out if it
should be formatted differently.

>> +Example:
>> +
>> +     watchdog: watchdog@...00000 {
>> +             compatible = "moxa,moxart-watchdog";
>> +             reg = <0x98500000 0x10>;
>> +             clocks = <&coreclk>;
>> +     };
>
> This seems sensible to me. I assume the watchdog is a standalone unit,
> and not part of some larger piece of IP?

I think it's standalone, unfortunately documentation on the SoC (which
this is likely part of) is not publicly available.

The register is not shared with anything else.

> This is a probe path. Is the use of unlikely() really appropriate here?
> I suspect it doesn't make any appreciable difference, and should go.

No, it just happened to get copied from a reference driver.

Best regards,
Jonas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/