linux-kernel - Re: [PATCH v7] watchdog: Add MOXA ART watchdog driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51FBE0D5.3070007@roeck-us.net>
Date:	Fri, 02 Aug 2013 09:39:49 -0700
From:	Guenter Roeck <linux@...ck-us.net>
To:	Mark Rutland <mark.rutland@....com>
CC:	Jonas Jensen <jonas.jensen@...il.com>,
	"linux-watchdog@...r.kernel.org" <linux-watchdog@...r.kernel.org>,
	"arnd@...db.de" <arnd@...db.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"wim@...ana.be" <wim@...ana.be>, "arm@...nel.org" <arm@...nel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v7] watchdog: Add MOXA ART watchdog driver

On 08/02/2013 04:41 AM, Mark Rutland wrote:
> On Mon, Jul 29, 2013 at 01:33:48PM +0100, Jonas Jensen wrote:
>> Add watchdog driver for MOXA ART SoCs.
>>
[ ... ]
>> +
>> +	err = watchdog_register_device(&moxart_wdt->dev);
>> +	if (unlikely(err))
>> +		return err;
>
> This is a probe path. Is the use of unlikely() really appropriate here?
> I suspect it doesn't make any appreciable difference, and should go.
>
Just wondering, for my education - why ? Is there s rule that unlikely()
shall not be used in the probe path ? If so, I would like to know it and
its reasoning to be able to apply it to my own reviews.

Thanks,
Guenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/