linux-kernel - Re: [PATCH v2] staging/lustre: lloop depends on BLOCK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130802031111.GA2329@kroah.com>
Date:	Fri, 2 Aug 2013 11:11:11 +0800
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Xiong Zhou <jencce.kernel@...il.com>
Cc:	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	Paul Bolle <pebolle@...cali.nl>,
	Jiri Kosina <trivial@...nel.org>,
	Peng Tao <bergwolf@...il.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Andreas Dilger <andreas.dilger@...el.com>
Subject: Re: [PATCH v2] staging/lustre: lloop depends on BLOCK

On Fri, Aug 02, 2013 at 10:20:28AM +0800, Xiong Zhou wrote:
> 
> 
> On Wed, 31 Jul 2013, Greg Kroah-Hartman wrote:
> 
> > On Wed, Jul 31, 2013 at 10:30:41AM +0800, Xiong Zhou wrote:
> > > From: Xiong Zhou <jencce.kernel@...il.com>
> > > 
> > > First version of this patch makes LUSTRE_FS depends on BLOCK.  Second
> > > version makes only lloop depends on BLOCK with a config option for this
> > > dependence, and remove unnecessary jdb header files which depends on
> > > BLOCK.
> > > 
> > > This version removes the wrapper ll_unregister_blkdev which depends on
> > > BLOCK in header and just call unregister_blkdev in lloop.c based on Peng
> > > Tao's comment.
> > 
> > This isn't all needed in the patch changelog info, just say what it
> > does.
> > 
> > Also, it doesn't apply for some reason, care to refresh this against my
> > latest tree and resend?
> > 
> > thanks,
> > 
> > greg k-h
> > 
> 
> OK, this patch is based on the staging-next branch of your staging tree.
> 
> 
> From: Xiong Zhou <jencce.kernel@...il.com>
> 
> Add a config option for llite/lloop in lustre driver, making it 
> depends on BLOCK to fix this better:
> drivers/staging/lustre/lustre/fid/../include/linux/lustre_compat25.h:117:2: 
> error: implicit declaration of function ‘unregister_blkdev’ 
> 
> Also, remove the wrapper ll_unregister_blkdev which depends on BLOCK in
> the header and just call unregister_blkdev in lloop.c based on Peng Tao's
> comment. Drop the redundant dependency on STAGING for LUSTRE_FS, remove 
> some unnecessary jdb header files which depends on BLOCK btw.
> 
> Signed-off-by: Xiong Zhou <jencce.kernel@...il.com>
> Reviewed-by: Peng Tao <tao.peng@....com>

Please resend this so I don't have to edit the body of the email, and
the Subject: line as well.

Also, you have a bunch of trailing whitespace in your changelog
comments, are you sure you want/need that?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/