linux-kernel - Re: [PATCH 08/16] x86, asmlinkage, kexec: Drop bogus asmlinkage in machine_kexec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130805231032.GQ19750@two.firstfloor.org>
Date:	Tue, 6 Aug 2013 01:10:32 +0200
From:	Andi Kleen <andi@...stfloor.org>
To:	"H. Peter Anvin" <hpa@...or.com>
Cc:	Andi Kleen <andi@...stfloor.org>, x86@...nel.org,
	linux-kernel@...r.kernel.org, Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH 08/16] x86, asmlinkage, kexec: Drop bogus asmlinkage in
 machine_kexec_32

On Mon, Aug 05, 2013 at 04:03:27PM -0700, H. Peter Anvin wrote:
> On 08/05/2013 03:02 PM, Andi Kleen wrote:
> > From: Andi Kleen <ak@...ux.intel.com>
> > 
> > A function pointer cannot be asmlinkage. Just drop it.
> > 
> > Signed-off-by: Andi Kleen <ak@...ux.intel.com>
> 
> Eh?  It certainly matters for the function pointer if it is regparm(0)
> or regparm(3), and the pointed-to function definitely assumes
> regparm(0).  So I think this patch is wrong, and if it isn't, it
> definitely needs better explanation why it isn't wrong.

Ok. Good point.

It causes compiler warnings with __attribute__((externally_visible))
because only a definition can be visible.

But yes it is needed for regparm.

So in a sense these two are incompatible. I guess it can be dropped
right now, as it's just a warning.

So please drop the patch and I'll too.
I'll not repost just for the drop, unless you ask me to 
(or other changes come up)

Longer term may need some different solution for this.

-Andi


-- 
ak@...ux.intel.com -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/