linux-kernel - Re: [PATCH V12 3/5] kvm : Fold pv_unhalt flag into GET_MP_STATE ioctl to aid migration

Open Source and information security mailing list archives

Message-ID: <CAG7+5M3_4D+hQn3xWefniKRWzkdraLCJKHG2PrLGPZLJQQUZVA@mail.gmail.com>
Date:	Tue, 6 Aug 2013 11:32:01 -0700
From:	Eric Northup <digitaleric@...gle.com>
To:	Raghavendra K T <raghavendra.kt@...ux.vnet.ibm.com>
Cc:	Gleb Natapov <gleb@...hat.com>, Ingo Molnar <mingo@...hat.com>,
	Jeremy Fitzhardinge <jeremy@...p.org>,
	"the arch/x86 maintainers" <x86@...nel.org>,
	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	Paolo Bonzini <pbonzini@...hat.com>,
	habanero@...ux.vnet.ibm.com, Rik van Riel <riel@...hat.com>,
	srivatsa.vaddagiri@...il.com, KVM <kvm@...r.kernel.org>,
	linux-doc@...r.kernel.org, Peter Zijlstra <peterz@...radead.org>,
	chegu_vinod@...com, drjones@...hat.com, ouyang@...pitt.edu,
	Andi Kleen <andi@...stfloor.org>, avi.kivity@...il.com,
	Thomas Gleixner <tglx@...utronix.de>,
	lf-virt <virtualization@...ts.linux-foundation.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V12 3/5] kvm : Fold pv_unhalt flag into GET_MP_STATE ioctl
 to aid migration

On Tue, Aug 6, 2013 at 11:23 AM, Raghavendra K T
<raghavendra.kt@...ux.vnet.ibm.com> wrote:
> kvm : Fold pv_unhalt flag into GET_MP_STATE ioctl to aid migration
>
> From: Raghavendra K T <raghavendra.kt@...ux.vnet.ibm.com>
>
> During migration, any vcpu that got kicked but did not become runnable
> (still in halted state) should be runnable after migration.

If this is about migration correctness, could it get folded into the
previous patch 2/5, so that there's not a broken commit which could
hurt bisection?

>
> Signed-off-by: Raghavendra K T <raghavendra.kt@...ux.vnet.ibm.com>
> Acked-by: Gleb Natapov <gleb@...hat.com>
> Acked-by: Ingo Molnar <mingo@...nel.org>
> ---
>  arch/x86/kvm/x86.c |    7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> index dae4575..1e73dab 100644
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -6284,7 +6284,12 @@ int kvm_arch_vcpu_ioctl_get_mpstate(struct kvm_vcpu *vcpu,
>                                     struct kvm_mp_state *mp_state)
>  {
>         kvm_apic_accept_events(vcpu);
> -       mp_state->mp_state = vcpu->arch.mp_state;
> +       if (vcpu->arch.mp_state == KVM_MP_STATE_HALTED &&
> +                                       vcpu->arch.pv.pv_unhalted)
> +               mp_state->mp_state = KVM_MP_STATE_RUNNABLE;
> +       else
> +               mp_state->mp_state = vcpu->arch.mp_state;
> +
>         return 0;
>  }
>
>
> _______________________________________________
> Virtualization mailing list
> Virtualization@...ts.linux-foundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/virtualization
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives