linux-kernel - Re: [PATCH v2 6/6] usb: host: tegra: Tegra30 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <520141F2.4060907@cogentembedded.com>
Date:	Tue, 06 Aug 2013 22:35:30 +0400
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Tuomas Tynkkynen <ttynkkynen@...dia.com>
CC:	balbi@...com, linux-tegra@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
	swarren@...dotorg.org, gregkh@...uxfoundation.org,
	stern@...land.harvard.edu
Subject: Re: [PATCH v2 6/6] usb: host: tegra: Tegra30 support

Hello.

On 08/06/2013 10:08 PM, Tuomas Tynkkynen wrote:

> The Tegra30 EHCI controller is mostly compatible with the Tegra20
> controller, except Tegra30 includes the HOSTPC register extension.
> The has_hostpc capability bit must be set in the ehci_hcd structure if
> the controller has such extensions. The new tegra_ehci_soc_config
> structure is added to describe the differences between the SoCs.

> Signed-off-by: Tuomas Tynkkynen <ttynkkynen@...dia.com>
> ---
>   drivers/usb/host/ehci-tegra.c | 34 +++++++++++++++++++++++++++++-----
>   1 file changed, 29 insertions(+), 5 deletions(-)

> diff --git a/drivers/usb/host/ehci-tegra.c b/drivers/usb/host/ehci-tegra.c
> index db8031f..c0d1f27 100644
> --- a/drivers/usb/host/ehci-tegra.c
> +++ b/drivers/usb/host/ehci-tegra.c
[...]
>   static int tegra_ehci_probe(struct platform_device *pdev)
>   {
> +	const struct of_device_id *match;
> +	const struct tegra_ehci_soc_config *soc_config;
>   	struct resource *res;
>   	struct usb_hcd *hcd;
>   	struct ehci_hcd *ehci;
> @@ -330,6 +351,13 @@ static int tegra_ehci_probe(struct platform_device *pdev)
>   	int irq;
>   	struct usb_phy *u_phy;
>
> +	match = of_match_device(tegra_ehci_of_match, &pdev->dev);
> +	if (!match) {
> +		dev_err(&pdev->dev, "Error: No device match found\n");
> +		return -ENODEV;
> +	}
> +	soc_config = (struct tegra_ehci_soc_config *)match->data;

    Aren't casts from 'const void *' automatic?

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/