linux-kernel - Re: [PATCH 0/2] kernel/sys.c: for setfsgid(), return the current gid when error occurs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXu5j+J=y-+wnkXV_wLJnoCOupFGk8GwvHjJz2oWCiZt_oQGQ@mail.gmail.com>
Date:	Tue, 6 Aug 2013 11:36:44 -0700
From:	Kees Cook <keescook@...omium.org>
To:	Chen Gang <gang.chen@...anux.com>
Cc:	Al Viro <viro@...iv.linux.org.uk>, Oleg Nesterov <oleg@...hat.com>,
	Robin Holt <holt@....com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 0/2] kernel/sys.c: for setfsgid(), return the current gid
 when error occurs

On Tue, Aug 6, 2013 at 1:00 AM, Chen Gang <gang.chen@...anux.com> wrote:
> They are 2 related patches for setfsgid().
>
> Patch 1 for bug fix: return the current gid when error occurs.
> Patch 2 for cleaning code: remove useless variable 'old_fsgid'.
>
> Signed-off-by: Chen Gang <gang.chen@...anux.com>
> --
>  kernel/sys.c |   15 +++++----------
>  1 files changed, 5 insertions(+), 10 deletions(-)

Making a change like this might have dramatic effects. So, a few
questions, to help better understand:

How long as the behavior been this way on Linux?
What is the origin of the documentation that states it differently?
Do existing userspace tools already depend on the current behavior?
What specific problem will be solved by changing this?

Thanks,

-Kees

-- 
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/