linux-kernel - Re: [PATCH V2 5/6] cpuidle/powerpc: Backend-powerpc idle driver for powernv and pseries.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1375832471.5600.41.camel@snotra.buserror.net>
Date:	Tue, 6 Aug 2013 18:41:11 -0500
From:	Scott Wood <scottwood@...escale.com>
To:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
CC:	Deepthi Dharwar <deepthi@...ux.vnet.ibm.com>,
	<daniel.lezcano@...aro.org>, <linux-kernel@...r.kernel.org>,
	<michael@...erman.id.au>, <srivatsa.bhat@...ux.vnet.ibm.com>,
	<preeti@...ux.vnet.ibm.com>, <svaidy@...ux.vnet.ibm.com>,
	<linuxppc-dev@...ts.ozlabs.org>, <rjw@...k.pl>,
	<dongsheng.wang@...escale.com>, <linux-pm@...r.kernel.org>
Subject: Re: [PATCH V2 5/6] cpuidle/powerpc: Backend-powerpc idle driver for
 powernv and pseries.

On Wed, 2013-08-07 at 09:30 +1000, Benjamin Herrenschmidt wrote:
> On Tue, 2013-08-06 at 18:08 -0500, Scott Wood wrote:
> > Here's another example.  get_lppaca() will only build on book3s -- and
> > yet we get requests for e500 code to use this file.
> 
> Indeed, Besides there is already accessors afaik for lppaca that compile
> to nothing on E (and if not they would be trivial to add).

I don't see such an accessor, but if there were, what would happen when
the caller goes on to dereference that nothing?

There is an accessor for shared_proc specifically (in the spinlock code)
-- not that it would be much help on booke to just compile away that
check and always select one of the pseries state tables over the other.

-Scott



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/