linux-kernel - Re: [PATCH V9 05/14] perf tools: tidy up sample parsing overflow checking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 07 Aug 2013 17:54:08 +0900
From:	Namhyung Kim <namhyung@...nel.org>
To:	Adrian Hunter <adrian.hunter@...el.com>
Cc:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	linux-kernel@...r.kernel.org, David Ahern <dsahern@...il.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Jiri Olsa <jolsa@...hat.com>, Mike Galbraith <efault@....de>,
	Paul Mackerras <paulus@...ba.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Stephane Eranian <eranian@...gle.com>,
	Ingo Molnar <mingo@...nel.org>
Subject: Re: [PATCH V9 05/14] perf tools: tidy up sample parsing overflow checking

On Wed, 07 Aug 2013 11:19:32 +0300, Adrian Hunter wrote:
> On 07/08/13 11:09, Namhyung Kim wrote:
>> On Mon,  5 Aug 2013 19:26:25 +0300, Adrian Hunter wrote:
>>> The size of data retrieved from a sample event must be
>>> validated to ensure it does not go past the end of the
>>> event.  That was being done sporadically and without
>>> considering integer overflows.
>> 
>> Wouldn't it be great if the macro (or something) can do all three things
>> together - checking overflow, getting current value (pointer) and
>> advancing the array to the size?  Is that possible?
>
> Macros are not the answer to everything.

Right.

But I was seeing repeating patterns of the three.. so I asked if there's
a better alternative.

Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/