linux-kernel - Re: [PATCH 0/8] rcu: Ensure rcu read site is deadlock-immunity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130807123827.GB4306@linux.vnet.ibm.com>
Date:	Wed, 7 Aug 2013 05:38:27 -0700
From:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To:	Lai Jiangshan <laijs@...fujitsu.com>
Cc:	Steven Rostedt <rostedt@...dmis.org>,
	Peter Zijlstra <peterz@...radead.org>,
	linux-kernel@...r.kernel.org, C.Emde@...dl.org
Subject: Re: [PATCH 0/8] rcu: Ensure rcu read site is deadlock-immunity

On Wed, Aug 07, 2013 at 06:24:56PM +0800, Lai Jiangshan wrote:
> Although all articles declare that rcu read site is deadlock-immunity.
> It is not true for rcu-preempt, it will be deadlock if rcu read site
> overlaps with scheduler lock.

The real rule is that if the scheduler does its outermost rcu_read_unlock()
with one of those locks held, it has to have avoided enabling preemption
through the entire RCU read-side critical section.

That said, avoiding the need for this rule would be a good thing.

How did you test this?  The rcutorture tests will not exercise this.
(Intentionally so, given that it can deadlock!)

> ec433f0c, 10f39bb1 and 016a8d5b just partially solve it. But rcu read site
> is still not deadlock-immunity. And the problem described in 016a8d5b
> is still existed(rcu_read_unlock_special() calls wake_up).
> 
> The problem is fixed in patch5.

This is going to require some serious review and testing.  One requirement
is that RCU priority boosting not persist significantly beyond the
re-enabling of interrupts associated with the irq-disabled lock.  To do
otherwise breaks RCU priority boosting.  At first glance, the added
set_need_resched() might handle this, but that is part of the review
and testing required.

Steven, would you and Carsten be willing to try this and see if it
helps with the issues you are seeing in -rt?  (My guess is "no", since
a deadlock would block forever rather than waking up after a couple
thousand seconds, but worth a try.)

							Thanx, Paul

> Lai Jiangshan (8):
>   rcu: add a warn to rcu_preempt_note_context_switch()
>   rcu: rcu_read_unlock_special() can be nested in irq/softirq 10f39bb1
>   rcu: keep irqs disabled in rcu_read_unlock_special()
>   rcu: delay task rcu state cleanup in exit_rcu()
>   rcu: eliminate rcu read site deadlock
>   rcu: call rcu_read_unlock_special() in rcu_preempt_check_callbacks()
>   rcu: add # of deferred _special() statistics
>   rcu: remove irq work for rsp_wakeup()
> 
>  include/linux/rcupdate.h |    2 +-
>  kernel/rcupdate.c        |    2 +-
>  kernel/rcutree.c         |   17 +--------
>  kernel/rcutree.h         |    2 +-
>  kernel/rcutree_plugin.h  |   82 ++++++++++++++++++++++++++++++++++-----------
>  kernel/rcutree_trace.c   |    1 +
>  6 files changed, 68 insertions(+), 38 deletions(-)
> 
> -- 
> 1.7.4.4
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/