linux-kernel - Re: [PATCH 7/8] rcu: add # of deferred

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130807164200.GD4306@linux.vnet.ibm.com>
Date:	Wed, 7 Aug 2013 09:42:00 -0700
From:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To:	Lai Jiangshan <laijs@...fujitsu.com>
Cc:	Steven Rostedt <rostedt@...dmis.org>,
	Peter Zijlstra <peterz@...radead.org>,
	linux-kernel@...r.kernel.org, Dipankar Sarma <dipankar@...ibm.com>
Subject: Re: [PATCH 7/8] rcu: add # of deferred _special() statistics

On Wed, Aug 07, 2013 at 06:25:03PM +0800, Lai Jiangshan wrote:
> Signed-off-by: Lai Jiangshan <laijs@...fujitsu.com>
> ---
>  kernel/rcutree.h        |    1 +
>  kernel/rcutree_plugin.h |    1 +
>  kernel/rcutree_trace.c  |    1 +
>  3 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/kernel/rcutree.h b/kernel/rcutree.h
> index 4a39d36..a5e9643 100644
> --- a/kernel/rcutree.h
> +++ b/kernel/rcutree.h
> @@ -290,6 +290,7 @@ struct rcu_data {
>  	unsigned long	n_force_qs_snap;
>  					/* did other CPU force QS recently? */
>  	long		blimit;		/* Upper limit on a processed batch */
> +	unsigned long	n_defer_special;/* # of deferred _special() */
> 
>  	/* 3) dynticks interface. */
>  	struct rcu_dynticks *dynticks;	/* Shared per-CPU dynticks state. */
> diff --git a/kernel/rcutree_plugin.h b/kernel/rcutree_plugin.h
> index c9ff9f1..d828eec 100644
> --- a/kernel/rcutree_plugin.h
> +++ b/kernel/rcutree_plugin.h
> @@ -396,6 +396,7 @@ void rcu_read_unlock_special(struct task_struct *t, bool unlock)
>  		 * is still unlikey to be true.
>  		 */
>  		if (unlikely(unlock && irqs_disabled_flags(flags))) {
> +			this_cpu_ptr(&rcu_preempt_data)->n_defer_special++;
>  			set_need_resched();
>  			local_irq_restore(flags);
>  			return;
> diff --git a/kernel/rcutree_trace.c b/kernel/rcutree_trace.c
> index cf6c174..17d8b2c 100644
> --- a/kernel/rcutree_trace.c
> +++ b/kernel/rcutree_trace.c
> @@ -149,6 +149,7 @@ static void print_one_rcu_data(struct seq_file *m, struct rcu_data *rdp)
>  	seq_printf(m, " ci=%lu nci=%lu co=%lu ca=%lu\n",

The above "\n" needs to be removed.  (Fixed while queueing.)

							Thanx, Paul

>  		   rdp->n_cbs_invoked, rdp->n_nocbs_invoked,
>  		   rdp->n_cbs_orphaned, rdp->n_cbs_adopted);
> +	seq_printf(m, " ds=%lu\n", rdp->n_defer_special);
>  }
> 
>  static int show_rcudata(struct seq_file *m, void *v)
> -- 
> 1.7.4.4
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/