linux-kernel - Re: [PATCH] clocksource: add an "menu" item to Kconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <520273FB.3030103@linaro.org>
Date:	Wed, 07 Aug 2013 09:21:15 -0700
From:	John Stultz <john.stultz@...aro.org>
To:	Sebastian Andrzej Siewior <bigeasy@...utronix.de>
CC:	Thomas Gleixner <tglx@...utronix.de>, linux-kernel@...r.kernel.org,
	Linus Walleij <linus.walleij@...aro.org>,
	Mattias Wallin <mattias.wallin@...ricsson.com>,
	Fabio Baltieri <fabio.baltieri@...aro.org>
Subject: Re: [PATCH] clocksource: add an "menu" item to Kconfig

On 08/07/2013 03:56 AM, Sebastian Andrzej Siewior wrote:
> This patch adds a menu item to clocksource' Kconfig file. Without it the
> changeable items look somehow lost in the main drivers' menu

So I'd like to push back on this a bit and ask why we need user-visible 
clocksource config options?

I'm much prefer the platform options select the needed clocksources, and 
not leave it up to the user (who really doesn't want to go digging 
around to find the clocksource sub-menu under drivers, and scan a list 
of 100 options that aren't possible on their hardware).

For an example of what I consider bad behavior here, see the RTC driver 
directory - at a certain point they just become hashes: "Oh no.. you 
selected rtc-387aae6fd, on your hardware, you need rtc-adfb8e5".

It really just seems like it forces more unnecessary options on the user 
and more ways to build a kernel that won't boot.

I do get you're trying to fix up the bad situation, caused by 
user-prompts slipping into the Kconfig.

But I might prefer a patch closer to whats below.

thanks
-john

diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
index b7b9b04..b3050db 100644
--- a/drivers/clocksource/Kconfig
+++ b/drivers/clocksource/Kconfig
@@ -57,14 +57,14 @@ config CLKSRC_NOMADIK_MTU_SCHED_CLOCK
  	  Use the Multi Timer Unit as the sched_clock.

  config CLKSRC_DBX500_PRCMU
-	bool "Clocksource PRCMU Timer"
+	bool
  	depends on UX500_SOC_DB8500
  	default y
  	help
  	  Use the always on PRCMU Timer as clocksource

  config CLKSRC_DBX500_PRCMU_SCHED_CLOCK
-	bool "Clocksource PRCMU Timer sched_clock"
+	bool
  	depends on (CLKSRC_DBX500_PRCMU && !CLKSRC_NOMADIK_MTU_SCHED_CLOCK)
  	default y
  	help

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/