linux-kernel - Re: [PATCH 1/8] ARM: at91: move peripheral id definitions to dt-bindings include dir

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201308072224.30614.arnd@arndb.de>
Date:	Wed, 7 Aug 2013 22:24:30 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Boris BREZILLON <b.brezillon@...rkiz.com>
Cc:	Nicolas Ferre <nicolas.ferre@...el.com>,
	"Jean-Christophe Plagniol-Villard" <plagnioj@...osoft.com>,
	Ludovic Desroches <ludovic.desroches@...el.com>,
	Russell King <linux@....linux.org.uk>,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 1/8] ARM: at91: move peripheral id definitions to dt-bindings include dir

On Thursday 01 August 2013, Boris BREZILLON wrote:
> 
> This patch moves peripheral id definitions from machine specific include
> dir (arch/arm/mach-at91/include/mach/'soc-name'.h) to dt-bindinds include
> dir (include/dt-bindings/at91/'soc-name'/peripherals.h).
> 
> These definitions will be used inside dt to define interrupt ids and
> peripheral clk ids.
> 
> Signed-off-by: Boris BREZILLON <b.brezillon@...rkiz.com>

This seems counterproductive, why would you do that?

There is no sharing of identifiers across SoCs here, you just move the
data around, and changing the .dts files to use the abstract macros would
just end up making them harder to understand, not easier, since you then
have to look up the numbers in another file.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/