linux-kernel - Re: [PATCH] kernel/sysctl_binary.c: improve the usage of return value 'result'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1375855849.2424.82.camel@joe-AO722>
Date:	Tue, 06 Aug 2013 23:10:49 -0700
From:	Joe Perches <joe@...ches.com>
To:	Li Zefan <lizefan@...wei.com>
Cc:	Chen Gang <gang.chen@...anux.com>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Al Viro <viro@...iv.linux.org.uk>, xi.wang@...il.com,
	nicolas.dichtel@...nd.com,
	Andrew Morton <akpm@...ux-foundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] kernel/sysctl_binary.c: improve the usage of return
 value 'result'

On Wed, 2013-08-07 at 13:56 +0800, Li Zefan wrote:
> >> The right answer to the code is to config it out and then you don't have
> >> to worry about it one way or another.
[]
> > Hmm... do you mean you spend 5 minutes to get a conclusion ? if so,
> > better not use word 'seems' which is not a suitable word appeared in
> > the results, proofs or conclusions.
[]
> You are too bad in english to do kernel development. You don't seem to
> know how to communicate in english...

I don't think that's true.

For instance, pessimization is a pretty
obscure word.  Most native English speakers
could probably guess what it meant, but I
couldn't hold any low opinion of non-native
speaker that asked "what does that mean".

The code communicates just fine.

Chen Gang could be a bit more careful when
making significant changes to core kernel
facilities.

(said the guy that broke just printk)

I think the fluent English speakers can be
tolerant reasonably well when the code is
correct and compelling (and correct).

cheers, Joe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/