linux-kernel - Re: [PATCH] kernel/sysctl_binary.c: improve the usage of return value 'result'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5201E192.7060108@huawei.com>
Date:	Wed, 7 Aug 2013 13:56:34 +0800
From:	Li Zefan <lizefan@...wei.com>
To:	Chen Gang <gang.chen@...anux.com>
CC:	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Al Viro <viro@...iv.linux.org.uk>, <xi.wang@...il.com>,
	<nicolas.dichtel@...nd.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] kernel/sysctl_binary.c: improve the usage of return value
 'result'

>> The right answer to the code is to config it out and then you don't have
>> to worry about it one way or another.
>>
> 
> Pardon?
> 
> Excuse me, my English is not quite well, I don't quite understand your
> meaning, could you please repeat again in details or say more clearly ?
> 
> 
>> The sysctl binary path has never been properly maintained and I don't
>> intend to start.   But I will spend 5 minutes to say this patch seems to
>> make the code worse not better.
>>
> 
> I guess no one ever invited you to maintain this file (for just as you
> said, this file will be removed), so don't worry about it.
> 
> Hmm... do you mean you spend 5 minutes to get a conclusion ? if so,
> better not use word 'seems' which is not a suitable word appeared in
> the results, proofs or conclusions.
> 

To be honest...

You are too bad in english to do kernel development. You don't seem to
know how to communicate in english...

And people easily get frustrated or even pissed off when discussing with
you. That's why tglx descided to put your emails into /dev/null...

> At least, one conclusion is: this patch switches from old-style to
> new-style, not for optimization.
> 
> But for sysctl_getname() and "checkpatch.pl" of this patch, better to
> get more discussion.
> 
> Is it OK ?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/