linux-kernel - Re: [PATCH 2/2] Staging: BCM: Removed more whitespace/Errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 8 Aug 2013 23:44:55 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Paul McQuade <paulmcquad@...il.com>
Cc:	gregkh@...uxfoundation.org,
	Linux-Devel <devel@...verdev.osuosl.org>,
	Linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] Staging: BCM: Removed more whitespace/Errors

On Thu, Aug 08, 2013 at 06:03:49PM +0100, Paul McQuade wrote:
> -int InterfaceFileDownload( PVOID psIntfAdapter,
> -                        struct file *flp,
> -                        unsigned int on_chip_loc);
> +int InterfaceFileDownload(PVOID psIntfAdapter,
> +						struct file *flp,
> +						unsigned int on_chip_loc);


The very first line in this patch is totally wrong...  :(

This is an automated patch.  I'm not going to review any further.
Automated patches create a problem for reviews because they are
far harder to review than they are to generate.  I'm not sure what
the solution is...

Anyway, the patch is very wrong.

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/