linux-kernel - Re: [PATCH 2/2] Staging: BCM: Removed more whitespace/Errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 08 Aug 2013 14:03:08 -0700
From:	Joe Perches <joe@...ches.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Paul McQuade <paulmcquad@...il.com>, gregkh@...uxfoundation.org,
	Linux-Devel <devel@...verdev.osuosl.org>,
	Linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] Staging: BCM: Removed more whitespace/Errors

On Thu, 2013-08-08 at 23:44 +0300, Dan Carpenter wrote:
> On Thu, Aug 08, 2013 at 06:03:49PM +0100, Paul McQuade wrote:
> > -int InterfaceFileDownload( PVOID psIntfAdapter,
> > -                        struct file *flp,
> > -                        unsigned int on_chip_loc);
> > +int InterfaceFileDownload(PVOID psIntfAdapter,
> > +						struct file *flp,
> > +						unsigned int on_chip_loc);
> 
> 
> The very first line in this patch is totally wrong...  :(
> 
> This is an automated patch.

It is?

It doesn't look like an automated patch to me.
It looks like there are too many different style
choices for it to have been done by a machine.

Why do you think that?

Paul, how did you create this patch?

Dan, if you get a chance, could you try to use
checkpatch with the --fix option with specific
--types like SPACING and PARENTHESIS_ALIGNMENT
and tell me if you think it's OK?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/