linux-kernel - Re: [PATCH v2 6/6] usb: host: tegra: Tegra30 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130809133722.GK12041@radagast>
Date:	Fri, 9 Aug 2013 16:37:22 +0300
From:	Felipe Balbi <balbi@...com>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
CC:	Tuomas Tynkkynen <ttynkkynen@...dia.com>,
	"balbi@...com" <balbi@...com>,
	"linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"swarren@...dotorg.org" <swarren@...dotorg.org>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"stern@...land.harvard.edu" <stern@...land.harvard.edu>
Subject: Re: [PATCH v2 6/6] usb: host: tegra: Tegra30 support

On Tue, Aug 06, 2013 at 11:27:11PM +0400, Sergei Shtylyov wrote:
> Hello.
> 
> On 08/06/2013 11:16 PM, Tuomas Tynkkynen wrote:
> 
> >[...]
> 
> >>>+	match = of_match_device(tegra_ehci_of_match, &pdev->dev);
> >>>+	if (!match) {
> >>>+		dev_err(&pdev->dev, "Error: No device match found\n");
> >>>+		return -ENODEV;
> >>>+	}
> >>>+	soc_config = (struct tegra_ehci_soc_config *)match->data;
> 
> >>     Aren't casts from 'const void *' automatic?
> 
> >>WBR, Sergei
> 
> >Indeed they are, but those explicit casts seem to be used in many places in the kernel.
> 
>    I suspect people just don't know C well enough. They are also
> being gradually removed.

yeah, please resend with the cast removed. Also, put Tested-by, Acked-by
and Reviewed-by in place.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)