linux-kernel - Re: [RFC 0/3] Add madvise(..., MADV

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALCETrU6j=X0KcuiNQxcsBiwD-o+PcDVbA2usV+fr+8M-1zm9Q@mail.gmail.com>
Date:	Fri, 9 Aug 2013 10:36:41 -0700
From:	Andy Lutomirski <luto@...capital.net>
To:	Jan Kara <jack@...e.cz>
Cc:	Dave Hansen <dave.hansen@...el.com>, linux-mm@...ck.org,
	linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC 0/3] Add madvise(..., MADV_WILLWRITE)

On Fri, Aug 9, 2013 at 12:55 AM, Jan Kara <jack@...e.cz> wrote:
> On Thu 08-08-13 15:58:39, Dave Hansen wrote:
>> I was coincidentally tracking down what I thought was a scalability
>> problem (turned out to be full disks :).  I noticed, though, that ext4
>> is about 20% slower than ext2/3 at doing write page faults (x-axis is
>> number of tasks):
>>
>> http://www.sr71.net/~dave/intel/page-fault-exts/cmp.html?1=ext3&2=ext4&hide=linear,threads,threads_idle,processes_idle&rollPeriod=5
>>
>> The test case is:
>>
>>       https://github.com/antonblanchard/will-it-scale/blob/master/tests/page_fault3.c
>   The reason is that ext2/ext3 do almost nothing in their write fault
> handler - they are about as fast as it can get. ext4 OTOH needs to reserve
> blocks for delayed allocation, setup buffers under a page etc. This is
> necessary if you want to make sure that if data are written via mmap, they
> also have space available on disk to be written to (ext2 / ext3 do not care
> and will just drop the data on the floor if you happen to hit ENOSPC during
> writeback).

Out of curiosity, why does ext4 need to set up buffers?  That is, as
long as the fs can guarantee that there is reserved space to write out
the page, why isn't it sufficient to just mark the page dirty and let
the writeback code set up the buffers?

>
> I'm not saying ext4 write fault path cannot possibly be optimized (noone
> seriously looked into that AFAIK so there may well be some low hanging
> fruit) but it will always be slower than ext2/3. A more meaningful
> comparison would be with filesystems like XFS which make similar guarantees
> regarding data safety.

FWIW, back when I actually tested this stuff, I had awful performance
on XFS, btrfs, and ext4.  But I'm really only interested in the
whether IO (or waiting for contended locks) happens on faults or not
-- a handful of microseconds while the fs allocates something from a
slab doesn't really bother me.


--Andy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/