linux-kernel - Re: [PATCH 2/5] crypto/camellia_generic.c: convert comma to semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1376151557.2083.35.camel@joe-AO722>
Date:	Sat, 10 Aug 2013 09:19:17 -0700
From:	Joe Perches <joe@...ches.com>
To:	Julia Lawall <Julia.Lawall@...6.fr>
Cc:	Herbert Xu <herbert@...dor.apana.org.au>,
	kernel-janitors@...r.kernel.org,
	"David S. Miller" <davem@...emloft.net>,
	linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
	trivial@...nel.org
Subject: Re: [PATCH 2/5] crypto/camellia_generic.c: convert comma to
 semicolon

On Sat, 2013-08-10 at 17:40 +0200, Julia Lawall wrote:
> Replace a comma between expression statements by a semicolon.
[]
> This patch is separate from the others because the code appears to be
> machine-generated.

It may have once been machine generated, but it's not now.
It's been modified several times by human generated patches.

> diff --git a/crypto/camellia_generic.c b/crypto/camellia_generic.c
[]
> @@ -388,7 +388,7 @@ static void camellia_setup_tail(u32 *subkey, u32 *subL, u32 *subR, int max)
[]
> -	dw = subL[1] & subL[9],
> +	dw = subL[1] & subL[9];
>  		subR[1] ^= rol32(dw, 1); /* modified for FLinv(kl2) */

Perhaps you can (auto?) fix the indentation
on the next line too?

> @@ -397,7 +397,7 @@ static void camellia_setup_tail(u32 *subkey, u32 *subL, u32 *subR, int max)
[]
> -	dw = subL[1] & subL[17],
> +	dw = subL[1] & subL[17];
>  		subR[1] ^= rol32(dw, 1); /* modified for FLinv(kl4) */

etc...


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/