linux-kernel - Re: [PATCH 2/5] crypto/camellia_generic.c: convert comma to semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1308101825220.2076@localhost6.localdomain6>
Date:	Sat, 10 Aug 2013 18:25:54 +0200 (CEST)
From:	Julia Lawall <julia.lawall@...6.fr>
To:	Joe Perches <joe@...ches.com>
cc:	Julia Lawall <Julia.Lawall@...6.fr>,
	Herbert Xu <herbert@...dor.hengli.com.au>,
	kernel-janitors@...r.kernel.org,
	"David S. Miller" <davem@...emloft.net>,
	linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
	trivial@...nel.org
Subject: Re: [PATCH 2/5] crypto/camellia_generic.c: convert comma to
 semicolon

On Sat, 10 Aug 2013, Joe Perches wrote:

> On Sat, 2013-08-10 at 17:40 +0200, Julia Lawall wrote:
> > Replace a comma between expression statements by a semicolon.
> []
> > This patch is separate from the others because the code appears to be
> > machine-generated.
> 
> It may have once been machine generated, but it's not now.
> It's been modified several times by human generated patches.
> 
> > diff --git a/crypto/camellia_generic.c b/crypto/camellia_generic.c
> []
> > @@ -388,7 +388,7 @@ static void camellia_setup_tail(u32 *subkey, u32 *subL, u32 *subR, int max)
> []
> > -	dw = subL[1] & subL[9],
> > +	dw = subL[1] & subL[9];
> >  		subR[1] ^= rol32(dw, 1); /* modified for FLinv(kl2) */
> 
> Perhaps you can (auto?) fix the indentation
> on the next line too?

OK, I'll take care of it.

julia
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/