linux-kernel - Re: [PATCH 07/10] staging: ozwpan: Make oz_hcd_pd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 13 Aug 2013 18:40:05 +0100
From:	Rupesh Gujare <rupesh.gujare@...el.com>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
CC:	<devel@...uxdriverproject.org>, <dan.carpenter@...cle.com>,
	<linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<gregkh@...uxfoundation.org>
Subject: Re: [PATCH 07/10] staging: ozwpan: Make oz_hcd_pd_departed() take
 a struct pointer.

On 13/08/13 18:35, Sergei Shtylyov wrote:
> Hello.
>
> On 08/13/2013 09:29 PM, Rupesh Gujare wrote:
>
>> oz_hcd_pd_departed() takes struct oz_port pointer instead of
>> void *, change function declaration to avoid ambiguity.
>
>> Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
>> Signed-off-by: Rupesh Gujare <rupesh.gujare@...el.com>
>> ---
>>   drivers/staging/ozwpan/ozhcd.c |    4 ++--
>>   drivers/staging/ozwpan/ozhcd.h |    2 +-
>>   2 files changed, 3 insertions(+), 3 deletions(-)
>
>> diff --git a/drivers/staging/ozwpan/ozhcd.c 
>> b/drivers/staging/ozwpan/ozhcd.c
>> index 73d80f2..ed3ffeb 100644
>> --- a/drivers/staging/ozwpan/ozhcd.c
>> +++ b/drivers/staging/ozwpan/ozhcd.c
>> @@ -720,9 +720,9 @@ out:
>>    * polled. We release the reference we hold on the PD.
>>    * Context: softirq
>>    */
>> -void oz_hcd_pd_departed(void *hport)
>> +void oz_hcd_pd_departed(struct oz_port *hport)
>>   {
>> -    struct oz_port *port = (struct oz_port *)hport;
>> +    struct oz_port *port = hport;
>
>    Do you really need a copy? Isn't it better to rename the parameter 
> and remove this line altogether?
>
> WBR, Sergei
>

Yes, that is the idea,  for next patch series, as I don't want to mix 
two changes in single patch.

-- 
Regards,
Rupesh Gujare

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/