linux-kernel - Re: [PATCH 10/10] staging: ozwpan: Separate success & failure case for oz_hcd_pd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130813230009.GT5502@mwanda>
Date:	Wed, 14 Aug 2013 02:00:09 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Rupesh Gujare <rupesh.gujare@...el.com>
Cc:	devel@...uxdriverproject.org, gregkh@...uxfoundation.org,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 10/10] staging: ozwpan: Separate success & failure case
 for oz_hcd_pd_arrived()

On Tue, Aug 13, 2013 at 06:29:26PM +0100, Rupesh Gujare wrote:
> From: Dan Carpenter <dan.carpenter@...cle.com>
> 
> This patch separates success & failure block along with fixing
> following issues:-
> 
> 1. The way oz_hcd_pd_arrived() looks now it's easy to think we free "ep" but
> actually we do this spaghetti thing of setting it to NULL on success.
> 
> 2. It is hard to read it because there are unlocks scattered throughout.
> 
> 3. Currently we set "ep" to NULL on the success path and then test it and or
> free it. In current code you have to scroll to the start of the function
> to read code.
> 
> Original patch was submitted by Dan here :-
> http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2013-August/040113.html
> 
> Signed-off-by: Rupesh Gujare <rupesh.gujare@...el.com>

Since you gave me the author tag for this then I'll sign off on this
as well.

Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/