| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1376490038-32382-1-git-send-email-ricardo.ribalda@gmail.com> Date: Wed, 14 Aug 2013 16:20:38 +0200 From: Ricardo Ribalda Delgado <ricardo.ribalda@...il.com> To: Linus Walleij <linus.walleij@...aro.org>, linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org Cc: Ricardo Ribalda Delgado <ricardo.ribalda@...il.com> Subject: [PATCH] gpio-pca953x: Fix read for chips with more than 8 gpios pca953x_read_single returns ONLY the value of the 8 inputs of the same bank. off can have a value from 0 to 15, therefore we have to find the offset of that gpio within that bank. Without this patch gpios 8-15 will always be read as zero. Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@...il.com> --- drivers/gpio/gpio-pca953x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c index 426c51d..1a7ab13 100644 --- a/drivers/gpio/gpio-pca953x.c +++ b/drivers/gpio/gpio-pca953x.c @@ -308,7 +308,7 @@ static int pca953x_gpio_get_value(struct gpio_chip *gc, unsigned off) return 0; } - return (reg_val & (1u << off)) ? 1 : 0; + return (reg_val & (1u << (off % BANK_SZ))) ? 1 : 0; } static void pca953x_gpio_set_value(struct gpio_chip *gc, unsigned off, int val) -- 1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists