linux-kernel - Re: [PATCH] gpio-pca953x: Fix read for chips with more than 8 gpios

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdbOPL7K2yc_zAo0-b-Y0mXCRXJfc7YYDhcb0K3uj76BBQ@mail.gmail.com>
Date:	Fri, 16 Aug 2013 17:21:18 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>
Cc:	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Andrew Ruder <andy@...uder.net>,
	Gregory CLEMENT <gregory.clement@...e-electrons.com>
Subject: Re: [PATCH] gpio-pca953x: Fix read for chips with more than 8 gpios

On Wed, Aug 14, 2013 at 4:20 PM, Ricardo Ribalda Delgado
<ricardo.ribalda@...il.com> wrote:

> pca953x_read_single returns ONLY the value of the 8 inputs of the
> same bank.
>
> off can have a value from 0 to 15, therefore we have to find the
> offset of that gpio within that bank.
>
> Without this patch gpios 8-15 will always be read as zero.
>
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>

Nice! But it turns out I already had an identical patch by
Andrew Ruder acked by Gregory Clement in my patch queue.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/