linux-kernel - Re: [PATCH 2/4] added regmap of AS3722

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130814152940.GT6427@sirena.org.uk>
Date:	Wed, 14 Aug 2013 16:29:40 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Florian Lobmaier <florian.lobmaier@....com>
Cc:	linux-kernel@...r.kernel.org, sameo@...ux.intel.com,
	lee.jones@...aro.org
Subject: Re: [PATCH 2/4] added regmap of AS3722

On Wed, Aug 14, 2013 at 04:54:56PM +0200, Florian Lobmaier wrote:

> +static bool as3722_readable(struct device *dev, unsigned int reg)
> +{
> +	switch (reg) {
> +	case AS3722_SD0_VOLTAGE_REG:

Are there any gaps in this register map?  If not just checking the range
would be easier (it looks like this is the case here).

> +	case AS3722_INTERRUPTSTATUS1_REG:
> +	case AS3722_INTERRUPTSTATUS2_REG:
> +	case AS3722_INTERRUPTSTATUS3_REG:
> +	case AS3722_INTERRUPTSTATUS4_REG:

> +static bool as3722_volatile(struct device *dev, unsigned int reg)
> +{
> +	return false;
> +}

At least the interrupt status register above should be volatile
otherwise you'll never be able to read the actual stauts.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)