linux-kernel - Re: [PATCH 4/4] added ams AS3722 register include file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130814153325.GG4046@lee--X1>
Date:	Wed, 14 Aug 2013 16:33:25 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Florian Lobmaier <florian.lobmaier@....com>
Cc:	linux-kernel@...r.kernel.org, sameo@...ux.intel.com
Subject: Re: [PATCH 4/4] added ams AS3722 register include file

> ---
>  include/linux/mfd/as3722-reg.h |  495 ++++++++++++++++++++++++++++++++++++++++

So the way you've split up the patch isn't quite right. It shouldn't
be split by files, rather by functionality.

Quoting from Documentation/SubmittingPatches:

"If your changes produce a lot of deltas, you may want to look into
 splitting them into individual patches which modify things in
 logical stages.  This will facilitate easier reviewing by other
 kernel developers, very important if you want your patch accepted."

Note "logical stages".

So things like:

- Driver introduction including Kconfig and Makefile entries
- Resource allocation; memory and irqs
- Everything else, bit by bit

Within reason, the simpler the patches, they more likely they are to
be reviewed and accepted.

-- 
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/