linux-kernel - Re: [PATCH 2/3] Staging: olpc_dcon: replace some magic numbers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130816071338.GC26086@mwanda>
Date:	Fri, 16 Aug 2013 10:13:38 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Jens Frederich <jfrederich@...il.com>
Cc:	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	jon.nettleton@...il.com, dsd@...top.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] Staging: olpc_dcon: replace some magic numbers

On Thu, Aug 15, 2013 at 09:34:55PM +0200, Jens Frederich wrote:
> The 0x42 initialize squence 0x101 is wrong.  According to
> the specification Bit 8 is reserved, thus not in use.
> I removed it.

Really these code changes should be in a separate patch and labeled
"Don't set reserved bit." instead of hidden away inside a cleanup
patch.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/