linux-kernel - Re: [PATCH 13/37] cpufreq: exynos: don't initialize part of policy that is set by core too

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 18 Aug 2013 16:20:18 +0530
From:	amit daniel kachhap <amit.daniel@...sung.com>
To:	Viresh Kumar <viresh.kumar@...aro.org>
Cc:	"Rafael J. Wysocki" <rjw@...k.pl>,
	linaro-kernel <linaro-kernel@...ts.linaro.org>,
	"patches@...aro.org" <patches@...aro.org>, cpufreq@...r.kernel.org,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Kukjin Kim <kgene.kim@...sung.com>
Subject: Re: [PATCH 13/37] cpufreq: exynos: don't initialize part of policy
 that is set by core too

On Wed, Aug 14, 2013 at 7:02 PM, Viresh Kumar <viresh.kumar@...aro.org> wrote:
> Many common initializations of struct policy are moved to core now and hence
> this driver doesn't need to do it. This patch removes such code.
>
> Most recent of those changes is to call ->get() in the core after calling
> ->init().
>
> Cc: Kukjin Kim <kgene.kim@...sung.com>
> Signed-off-by: Viresh Kumar <viresh.kumar@...aro.org>
This consolidation work looks fine,
Acked-By: Amit Daniel Kachhap <amit.daniel@...sung.com>

Thanks,
Amit
> ---
>  drivers/cpufreq/exynos-cpufreq.c     | 2 --
>  drivers/cpufreq/exynos5440-cpufreq.c | 1 -
>  2 files changed, 3 deletions(-)
>
> diff --git a/drivers/cpufreq/exynos-cpufreq.c b/drivers/cpufreq/exynos-cpufreq.c
> index 79b869b..b1db082 100644
> --- a/drivers/cpufreq/exynos-cpufreq.c
> +++ b/drivers/cpufreq/exynos-cpufreq.c
> @@ -226,8 +226,6 @@ static struct notifier_block exynos_cpufreq_nb = {
>
>  static int exynos_cpufreq_cpu_init(struct cpufreq_policy *policy)
>  {
> -       policy->cur = policy->min = policy->max = exynos_getspeed(policy->cpu);
> -
>         /* set the transition latency value */
>         policy->cpuinfo.transition_latency = 100000;
>
> diff --git a/drivers/cpufreq/exynos5440-cpufreq.c b/drivers/cpufreq/exynos5440-cpufreq.c
> index 9a5ed485..91a64d6 100644
> --- a/drivers/cpufreq/exynos5440-cpufreq.c
> +++ b/drivers/cpufreq/exynos5440-cpufreq.c
> @@ -316,7 +316,6 @@ static int exynos_cpufreq_cpu_init(struct cpufreq_policy *policy)
>                 return ret;
>         }
>
> -       policy->cur = dvfs_info->cur_frequency;
>         policy->cpuinfo.transition_latency = dvfs_info->latency;
>         cpumask_setall(policy->cpus);
>
> --
> 1.7.12.rc2.18.g61b472e
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pm" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/