linux-kernel - Re: [PATCH] i2c-omap: always send stop after nack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130819135702.GC26587@radagast>
Date:	Mon, 19 Aug 2013 08:57:02 -0500
From:	Felipe Balbi <balbi@...com>
To:	Wolfram Sang <wsa@...-dreams.de>
CC:	Hein Tibosch <hein_tibosch@...oo.es>, <balbi@...com>,
	Grygorii Strashko <grygorii.strashko@...com>,
	Tony Lindgren <tony@...mide.com>,
	linux-i2c <linux-i2c@...r.kernel.org>,
	linux-omap <linux-omap@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] i2c-omap: always send stop after nack

On Mon, Aug 19, 2013 at 02:11:23PM +0200, Wolfram Sang wrote:
> Hi,
> 
> > > Which means your original patch starts to make a lot more sense. I
> > > wonder is this is really what we should be doing though - breaking out
> > > of the loop, I mean.
> 
> Yup, that is fine. I applied the old patch with Acks from Hein and
> Felipe to -next. Thanks!
> 
> > It looks like TI's i2c-davinci will have the same problem as i2c-omap,
> > and will need the same change.
> 
> Somebody up for this?

I would suggest deleting i2c-davinci and making sure it can use
i2c-omap. It's the same IP anyway. Just an older version which was used
back in OMAP1 times.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)