linux-kernel - Re: [PATCH 0/3] perf ui/gtk: Separate out GTK code to a shared object (v4)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130819140500.GA3053@ghostprotocols.net>
Date:	Mon, 19 Aug 2013 11:05:00 -0300
From:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>
To:	Namhyung Kim <namhyung@...nel.org>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 0/3] perf ui/gtk: Separate out GTK code to a shared
 object (v4)

Em Fri, Aug 09, 2013 at 03:28:06PM +0900, Namhyung Kim escreveu:
> This is v3 of gtk code separation patchset to reduce library

Not a major problem, but would be good if we were robust in this area:

    LINK /tmp/build/perf/perf
/usr/bin/ld: /tmp/build/perf/ui/gtk/browser.o: relocation R_X86_64_32
against `.rodata.str1.1' can not be used when making a shared object;
recompile with -fPIC
/tmp/build/perf/ui/gtk/browser.o: could not read symbols: Bad value
collect2: error: ld returned 1 exit status
make: *** [/tmp/build/perf/libperf-gtk.so] Error 1
make: *** Waiting for unfinished jobs....
make: Leaving directory `/home/git/linux/tools/perf'
[acme@zoo linux]$ 

This happened because I was retesting the whole series after noticing I
was testing as root, that has a symlink of ~acme/bin/perf to
~root/bin/perf but was lacking a symlink of ~acme/lib64/ to
~root/lib64/, so that as root perf could find the libperf-gtk.so file.

So I just rolled back the 3 patches in this series to rebuild and
retried, but when I reapplied the first patch in this series I got the
above error, i.e. the make process got confused and didn't properly
rebuilt a file in the expected format for linking, after forcefully
removing my build dir and rebuilding everything it got back to working.

But I expected that after the first patch 'perf --gtk' would work, and
it doesn't.

Now even after I applied the whole series I don't get --gtk to work,
neither as a non-root nor as root :-\

Investigating...

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/