[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <52127284.6030506@wwwdotorg.org>
Date: Mon, 19 Aug 2013 13:31:16 -0600
From: Stephen Warren <swarren@...dotorg.org>
To: George Cherian <george.cherian@...com>
CC: balbi@...com, myungjoo.ham@...sung.com, cw00.choi@...sung.com,
linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
devicetree@...r.kernel.org, grant.likely@...aro.org,
rob@...dley.net, ian.campbell@...rix.com, mark.rutland@....com,
pawel.moll@....com, rob.herring@...xeda.com,
linux-omap@...r.kernel.org, linux-usb@...r.kernel.org,
bcousson@...libre.com
Subject: Re: [PATCH 1/2] extcon: extcon-dra7xx: Add extcon driver for USB
ID detection
On 08/16/2013 04:13 AM, George Cherian wrote:
> Adding extcon driver for USB ID detection to dynamically
> configure USB Host/Peripheral mode.
> diff --git a/Documentation/devicetree/bindings/extcon/extcon-dra7xx.txt b/Documentation/devicetree/bindings/extcon/extcon-dra7xx.txt
> +EXTCON FOR DRA7xx
> +
> +Required Properties:
Please at lest explain what a DRA7xxx is, and the purpose of the HW
module this binding describes.
> + - compatible : Should be "ti,dra7xx-usb"
If this is a USB VID detector rather than a full USB host controller,
then "usb" in the binding is a bit over-reaching. Perhaps "-usb-vid" or
"-usb-vid-detector" would be more accurate.
> + - gpios : phandle to ID pin and interrupt gpio.
This isn't just a phandle; it's phandle+args, or a GPIO specifier. Some
reference should be made to ../gpio/gpio.txt for the format.
Why does the interrupt line need to be included in a list of GPIOs?
If the DRA7xxx is a VID detector, why does it even need/have any GPIOs
associated with it; surely it has a dedicated VID input pin. Can you
provide more details re: how the HW is structured.
> +Optional Properties:
> + - interrupt-parent : interrupt controller phandle
> + - interrupts : interrupt number
> +
> +
It's typical insert the following between those two blank lines:
Example:
... or delete one of the blank lines.
> +dra7x_extcon1 {
> + compatible = "ti,dra7xx-usb";
> + gpios = <&pcf_usb 1 0>,
> + <&gpio6 11 2>;
> + interrupt-parent = <&gpio6>;
> + interrupts = <11>;
> + };
> +
No need for that trailing blank line.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists