linux-kernel - Re: [PATCH 1/7] PCI: tegra: replace devm_request_and_ioremap by devm_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 19 Aug 2013 21:33:40 +0200
From:	Thierry Reding <thierry.reding@...il.com>
To:	Julia Lawall <julia.lawall@...6.fr>
Cc:	kernel-janitors@...r.kernel.org,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	Stephen Warren <swarren@...dotorg.org>,
	linux-tegra@...r.kernel.org, linux-pci@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/7] PCI: tegra: replace devm_request_and_ioremap by
 devm_ioremap_resource

On Mon, Aug 19, 2013 at 02:15:39PM +0200, Julia Lawall wrote:
> 
> 
> On Mon, 19 Aug 2013, Thierry Reding wrote:
> 
> > On Mon, Aug 19, 2013 at 02:07:54PM +0200, Julia Lawall wrote:
> > >
> > >
> > > On Mon, 19 Aug 2013, Thierry Reding wrote:
> > >
> > > > On Mon, Aug 19, 2013 at 01:20:35PM +0200, Julia Lawall wrote:
> > > > > From: Julia Lawall <Julia.Lawall@...6.fr>
> > > > >
> > > > > Use devm_ioremap_resource instead of devm_request_and_ioremap.
> > > > >
> > > > > This was done using the semantic patch
> > > > > scripts/coccinelle/api/devm_ioremap_resource.cocci
> > > > >
> > > > > Error-handling code was manually removed from the associated calls to
> > > > > platform_get_resource.
> > > > >
> > > > > Signed-off-by: Julia Lawall <Julia.Lawall@...6.fr>
> > > > >
> > > > > ---
> > > > > The first block of modified code is followed by a call to
> > > > > devm_request_mem_region for pcie->cs with no associated ioremap.  Should
> > > > > ioremap be used in this case as well?
> > > >
> > > > No. The pcie->cs resource is 256 MiB so it's challenging to map it at
> > > > once. Furthermore it requires a non-linear mapping so we do it on
> > > > demand.
> > >
> > > OK, thanks for the explanation.  Is the comment, though, a little
> > > misleading, since the mapping is not done here?
> > >
> > > /* request and remap configuration space */
> >
> > Yes, that's misleading. Given that it doesn't really add anything useful
> > information either, perhaps I should just remove it.
> 
> OK, or maybe something like
> 
> /* request configuration space, but remap later, on demand */
> 
> To make it clear that something different is intended than the
> devm_ioremap_resources that come just before..

Yes, that works for me too. Can you respin the patch with the comment
updated and my Acked-by and Tested-by so Bjorn can pick it up?

Thierry

Content of type "application/pgp-signature" skipped