linux-kernel - Re: commit 94fc5d9: chromium-sandbox core dumped

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFzH7DH0d+DXgQ6T3Us6job8OvVmCJXMp2z3xit86d0ZrA@mail.gmail.com>
Date:	Mon, 19 Aug 2013 13:25:10 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Emmanuel Benisty <benisty.e@...il.com>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Richard Genoud <richard.genoud@...il.com>,
	Al Viro <viro@...iv.linux.org.uk>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: commit 94fc5d9: chromium-sandbox core dumped

On Mon, Aug 19, 2013 at 11:48 AM, Emmanuel Benisty <benisty.e@...il.com> wrote:
>
> The following commit breaks chromium on my machine ("proc:
> return on proc_readdir error")
>
> Chromium breaks with:
>
> [269:269:0819/203839:FATAL:zygote_host_impl_linux.cc(195)] Check
> failed: pid_0. Did not find zygote process (using sandbox binary
> /usr/lib/chromium/chromium-sandbox)
> Aborted (core dumped)

Hmm. I think that Richard's patch is correct, but looking at all this,
it looks like the return value of proc_readdir() is broken.

The comment above proc_readdir_de() says

 * This returns non-zero if at EOF, so that the /proc
 * root directory can use this and check if it should
 * continue with the <pid> entries..

which is exactly what it should do. But the *code* does no such thing,
and instead always returns 0, breaking Richards patch.

I suspect that last "return 0" at the end should be "return 1". Does
that fix things for you? Untested.

Al? It looks to me like commit f0c3b5093add ("[readdir] convert
procfs") messed up when it changed proc_readdir_de() to not have all
those "goto out" things any more...

               Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/